-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platform.isAttached should return false if canvas is false-y #11707
Merged
LeeLenaleee
merged 2 commits into
chartjs:master
from
DAcodedBEAT:platform-is-attached-canvas-validation
Mar 11, 2024
Merged
platform.isAttached should return false if canvas is false-y #11707
LeeLenaleee
merged 2 commits into
chartjs:master
from
DAcodedBEAT:platform-is-attached-canvas-validation
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
approved these changes
Mar 8, 2024
LeeLenaleee
approved these changes
Mar 11, 2024
Hello @etimberg / @LeeLenaleee 👋 Thanks again for the prompt review and merge. Do you have an ETA for the release of 4.5.0 ? |
@chartjs When should I expect this to land? Should I run a fork in production in the interim? |
This was referenced Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior
isAttached()
fromplatform.dom.js
should only call_getParentNode()
on valid a truth-ycanvas
value.Current behavior
From sentry:
Reproducible sample
.
Optional extra steps/info to reproduce
No response
Context
_getParentNode
itself. I will defer that decision to the @chartjs maintainers if they want this changed.chart.js version
4.4.2
Browser name and version
Experienced on Chrome 122.0.0 according to my project's Sentry, but probably impacts others since this is missing a null check.
Link to your project
No response