Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License Update #1374

Merged
merged 4 commits into from
Oct 8, 2021
Merged

License Update #1374

merged 4 commits into from
Oct 8, 2021

Conversation

warengonzaga
Copy link
Member

I just update the license of animate.css as mentioned here: #1355

Copy link
Collaborator

@eltonmesquita eltonmesquita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the broken link to fix. The rest looks just fine. Thanks for this PR!

readme.md Outdated Show resolved Hide resolved
docs/index.html Show resolved Hide resolved
package.json Show resolved Hide resolved
@warengonzaga
Copy link
Member Author

Hi @eltonmesquita alright, I'll keep the naming convention into uppercase. Let me push the changes.

Copy link
Collaborator

@eltonmesquita eltonmesquita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll get this merged, but it'd be nice if you could revert the commit or use a fixup commit the next time you've got something reverted.

Besides that, very nice work! Thanks for that

@eltonmesquita eltonmesquita merged commit 847fdd2 into animate-css:main Oct 8, 2021
@Aspie96
Copy link

Aspie96 commented Dec 29, 2021

Note: you should preserve the previous license text in the project, if you have had contributors prior to this.

See: vcr/vcr#804
Also: https://ethicalsource.dev/blog/adopting-an-ethical-license/ (this one got writed as a consequence of the above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants