Fix: delay and repeat custom prop support on base class #1780
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1544
From the docs: Since version 4, Animate.css uses custom properties (also known as CSS variables) to define the animation's duration, delay, and iterations.
However, only
animation-duration
is defined on.animated
currently , so defining delay and repeat props on the element or at:root
have no effect unless you add one of the modifier classes.It would be possible to add the
delay-1s
and repeat-1
classes to trigger the expected behavior, but then you might get a mismatch between the prop value (say you pass in 1.5s on one element and 2 repeats on another, etc).By adding
animation-delay
andanimation-iteration-count
on the base class, explicit control can be set on each element and globally.